Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Wiki to Docs #2546

Merged
merged 2 commits into from
May 21, 2024
Merged

Migrate Wiki to Docs #2546

merged 2 commits into from
May 21, 2024

Conversation

vorburger
Copy link
Member

@vorburger vorburger commented May 15, 2024

@vorburger vorburger marked this pull request as ready for review May 15, 2024 20:03
@vorburger vorburger requested review from santosh-pingle and a team as code owners May 15, 2024 20:03
@vorburger vorburger requested a review from kevinmost May 15, 2024 20:03
@vorburger
Copy link
Member Author

vorburger commented May 15, 2024

@MJ1998 given that you had reviewed #2513, could I invite you to do the honors to R and perhaps LGTM & Merge this one as well? Thank You!

Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NITs.
LGTM

mkdocs.yaml Show resolved Hide resolved
mkdocs.yaml Show resolved Hide resolved
mkdocs.yaml Show resolved Hide resolved
docs/use/Extensions.md Show resolved Hide resolved
mkdocs.yaml Show resolved Hide resolved
@vorburger vorburger removed the request for review from kevinmost May 16, 2024 11:18
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MJ1998 MJ1998 enabled auto-merge (squash) May 21, 2024 14:50
@MJ1998 MJ1998 merged commit b1e6111 into master May 21, 2024
4 checks passed
@MJ1998 MJ1998 deleted the docs-wiki branch May 21, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants