Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FhirEngine interface method 'withTransaction' #2535

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

LZRS
Copy link
Collaborator

@LZRS LZRS commented May 6, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2531

Description
Support performing FhirEngine actions as a single atomic transaction

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

To support performing FhirEngine actions as a single atomic transaction
@LZRS LZRS requested review from santosh-pingle and a team as code owners May 6, 2024 21:40
@LZRS LZRS requested a review from shelaghm May 6, 2024 21:40
Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions for the api.

engine/src/main/java/com/google/android/fhir/FhirEngine.kt Outdated Show resolved Hide resolved
@LZRS LZRS force-pushed the 2531-fhirengine-interface branch from 13b83cb to bf90f8c Compare May 26, 2024 10:35
@LZRS LZRS force-pushed the 2531-fhirengine-interface branch from bf90f8c to 72be126 Compare May 26, 2024 10:44
@LZRS LZRS requested a review from aditya-07 May 27, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

Expose an interface to db.withtransaction through FhirEngine
2 participants