Ctx result consumption #319
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
force-pushed
the
signint_saviour
branch
4 times, most recently
from
d1ddfa4
to
2d387f2
Compare
|
well this needs a rebase 😂 |
goodboy
force-pushed
the
ctx_result_consumption
branch
from
0b3590c
to
b046cd3
Compare
goodboy
force-pushed
the
ctx_result_consumption
branch
from
b046cd3
to
f05364c
Compare
|
This is oddly causing a clustering test hang, seemingly todo with |
goodboy
force-pushed
the
ctx_result_consumption
branch
2 times, most recently
from
8b93a1b
to
2fe9a1a
Compare
Ahh i wonder if this was solved by #346 (comment)? Not even sure if this patchset ends up being necessary given all the work in #346, probably worth a test tho. |
The case exists where there is multiple tasks consuming from an open 2-way stream created via `Context.open_stream()` where a sibling task is pulling from the stream while some other task also calls `.result()`. Previously the `.result()` call would consume (drain) stream messages directly from the underlying mem chan which would mean any sibling task would not receive those same messages. Instead, make `.result()` check if a stream is open and instead consume (and discard) stream msgs using a `BroadcastReceiver` (via `MsgStream.subscribe()`) such that all interested tasks get copies of the same packets.
goodboy
force-pushed
the
ctx_result_consumption
branch
from
2fe9a1a
to
6120e99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handling of contex teardowns where IPC msgs might still be in transit that need to be discarded as well a more explicit tolerance for IPC transport failures when determining whether to send cancel request messages.