-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate config file for deprecated value #7705
base: main
Are you sure you want to change the base?
validate config file for deprecated value #7705
Conversation
Thanks for the PR! However, it looks incomplete and missing tests, could you finish it before requesting review? |
Hi @unknwon , yes. Noted, next time, will set a draft PR before asking for the review. Btw, I'm still creating the unit test. But I found some problems, I'm not sure how to test/assert the |
Yep, that's what I would do and recommend 👍 |
I do have more general question about whether we need this PR at all though. The tip of the Let's say we do agree it's a QoL improvement, the logic needs to be version aware because for example, All that to say, adding a comment saying something like "Delete this function after 0.14.0 is released." would be good enough. |
Oh, okay, it makes sense. Since it will be deleted in next version and can be repurpose later.
I see, okay, I'll close this PR. |
Hmm, sorry if I was misleading... didn't mean to close this PR. I think what's in the current diff still makes sense to the purpose of this PR. i.e. just do // warnDeprecated warns about deprecated configuration sections and options.
+//
+// NOTE: Delete this function after 0.14.0 is released.
func warnDeprecated(cfg *ini.File) []string { Then finish your TODOs and add tests. Sounds right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes i need
Describe the pull request
close: #6498
A clear and concise description of what the pull request is about, i.e. what problem should be fixed?
Link to the issue:
Checklist
Test plan