Style self-links to make them appear only on hover #9324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rburing
added
enhancement
area:class reference
Calinou
approved these changes
May 26, 2024
There was a problem hiding this comment.
Tested locally (together with godotengine/godot#91537), it works as expected.
simplescreenrecorder-2024-05-26_20.08.03.mp4
rburing
removed
the
waiting on PR merge
mhilbrunner
approved these changes
May 30, 2024
|
Thank you! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
css_self_links.mp4
On mobile the link appears by tapping on the line of e.g. the method signature (e.g. tapping on the method name).
The implementation is a bit of a hack, but it works. I would have preferred to add an attribute to the self-link to identify it more easily, but I didn't manage to do it with Sphinx (not sure it's possible).