fix: Restores old build output by removing package.json import #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenrui333
reviewed
May 13, 2024
Comment on lines
-13
to
-14
| "baseUrl": "src", | ||
| "resolveJsonModule": true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts the package.json import from
importtorequireRemoves
resolveJsonModulesfromtsconfig.jsonMotivation and Context
Fixes #2593
By including
resolveJsonModules: trueand usingimportfor thepackage.jsonin theindex.tsfor the cli dir, we ended up introducing an extra level into the build output as including the json import hoisted thesrcdir intodist.Fixed by restoring the previous code and ignoring the lint error.
Will follow-up with a new PR to get the version text in a different manner
Previous Behaviour / Output
Old dist output:
New Behaviour / Output
Current output:
How Has This Been Tested?
srcdir is not in the build outputScreenshots (if appropriate):