LSP: code action to remove redundant tuple in case subject #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Apr 30, 2024
| typ: &'ast Arc<Type>, | ||
| subjects: &'ast [ast::TypedExpr], | ||
| clauses: &'ast [ast::TypedClause], | ||
| ) { |
There was a problem hiding this comment.
Oh this is super cool! I love the approach you've taken here, and I think we could use it for lots of other things too.
Could we get more comments that detail what this class does and the approach it uses to doing it. Thank you
There was a problem hiding this comment.
Just to check, are you referring to the usage of the Visit trait?
There was a problem hiding this comment.
Everything! Ideally all logic should have comment explaining the intent in plain English as it's not clear if you either don't have context or are a newcomer to the codebase. Being approachable is super important for Gleam's long-term maintainability as we don't have a big corporate sponsor.
nicklimmm
force-pushed
the
remove-redundant-tuple-in-case-subject
branch
from
c1823ab
to
0be238d
Compare
nicklimmm
force-pushed
the
remove-redundant-tuple-in-case-subject
branch
from
0be238d
to
65ab5b9
Compare
|
Bumping in case you missed this @lpil |
lpil
reviewed
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2982
Supports batch removal.
Also adds a basic visitor pattern to walk the typed AST.