unqualified import completion #3054
Conversation
| @@ -166,6 +166,8 @@ | |||
|
|
|||
| - Go to definition now works for direct type annotations ([Ameen Radwan](https://github.com/Acepie)) | |||
|
|
|||
| - Completions are now provided for values and types for use in unqualified imports ([Ameen Radwan](https://github.com/Acepie)) | |||
There was a problem hiding this comment.
I think this is a little misleading as it will very rarely work. The cursor position will be outside the import definition at time of last successful compilation so it won't return any completions.
I think we may also have the same text edit bug with vscode
There was a problem hiding this comment.
This should work much better now. Didn't realize this was only working well because of auto bracket close before. lmk if this seems good enough now. If not I can change this
There was a problem hiding this comment.
I've just given this a try and it feels so nice! Thank you!!
|
Ok worked on this a bit and got something that works pretty nicely overall Screen.Recording.2024-04-29.at.6.47.39.AM.mov |
Acepie
force-pushed
the
completeUnqualifiedImports
branch
3 times, most recently
from
ed53720
to
ec36300
Compare
Acepie
force-pushed
the
completeUnqualifiedImports
branch
from
ec36300
to
ade819a
Compare
| @@ -166,6 +166,8 @@ | |||
|
|
|||
| - Go to definition now works for direct type annotations ([Ameen Radwan](https://github.com/Acepie)) | |||
|
|
|||
| - Completions are now provided for values and types for use in unqualified imports ([Ameen Radwan](https://github.com/Acepie)) | |||
There was a problem hiding this comment.
I've just given this a try and it feels so nice! Thank you!!
|
Thanks - This is awesome! |
Closes #2892
Checks existing imports in the current module to see what is already imported and then looks through the importing module to find everything else that is importable from that module