Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use SHAs for GitHub Actions instead of tags #3228

Merged
merged 1 commit into from
May 23, 2024

Conversation

jmeridth
Copy link
Member

Adhere to best security practices and use SHAs for GitHub Actions and not tags (they can be changed).

I used frizbee to do this.

brew install stacklok/tap/frizbee
frizbee ghactions -d .github/workflows/
  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


Adhere to best security practices and use SHAs for GitHub Actions
and not tags (they can be changed).

I used [`frizbee`](https://github.com/stacklok/frizbee) to do this.

`frizbee ghactions -d .github/workflows/`

Signed-off-by: jmeridth <jmeridth@gmail.com>
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ahpook ahpook added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit b95799f May 23, 2024
3 checks passed
@ahpook ahpook deleted the jm-shas-for-github-actions branch May 23, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants