test: separate test cases in util/tag-selector tests #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate tests in util_test.go and tag_selector_test.go into sub test cases. This improves the output of these tests and make clear what tests succeed/fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This PR separates tests in util_test.go and tag_selector_test.go into sub test cases.
This improves the output of these tests and makes clear what tests succeed/fail.
How this PR fixes the problem?
Use
testing.T's methodRunwhen asserting each case.What should your reviewer look out for in this PR?
You can see what the test changed into with
go test ./... -run='Compare|TagSelector' -vCheck lists
Additional Comments (if any)
{Please write here}
Which issue(s) does this PR fix?
I made no ISSUEs corresponding to this PR.