Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support grouping by date #228

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aeneasr
Copy link

@aeneasr aeneasr commented Feb 10, 2023

What does this do / why do we need it?

Grouping by .Author.Date is currently not possible because time.Time is not string

How this PR fixes the problem?

Adding a type switch allowing users to use Author.Date in the commit group commit_groups.group_by

What should your reviewer look out for in this PR?

Using time.Time currently defaults to the date. Itt might be desirable (in the future) to make this configurable, but in the interest of simplicity I chose to use the internationally acceptable date format YYYY-MM-DD.

Check lists

  • Test passed
  • Coding style (indentation, etc)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4143270565

  • 8 of 16 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 76.541%

Changes Missing Coverage Covered Lines Changed/Added Lines %
commit_extractor.go 8 16 50.0%
Totals Coverage Status
Change from base Build 4124882195: -0.2%
Covered Lines: 1850
Relevant Lines: 2417

💛 - Coveralls

@mavogel mavogel added this to the v0.16.0 milestone Feb 11, 2023
@mavogel
Copy link
Member

mavogel commented Feb 11, 2023

hi @aeneasr , thanks for contributing. Would you mind, merging / rebasing master and tackle the coverage? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants