feat: Add commits to Unreleased when no tags. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure what my next steps are or how to get the linting and test to turn green. Any suggestions? |
b01
force-pushed
the
issue-76-enhancement-when-no-tags-present
branch
from
103409b
to
c59129f
Compare
b01
force-pushed
the
issue-76-enhancement-when-no-tags-present
branch
from
c59129f
to
8cffe68
Compare
|
I've put this out there a while ago. I'm using this tool all the time. I've hit a place where this would be nice to have. I want to contribute instead of running off on my own fork. What can I do to get this merged in? Like why aren't the lint and test running? May I please have some guidance? |
b01
force-pushed
the
issue-76-enhancement-when-no-tags-present
branch
4 times, most recently
from
5bb5d0f
to
0d24f7b
Compare
|
I recently re-looked at this code and made changes. It now performs the expected behavior. |
b01
force-pushed
the
issue-76-enhancement-when-no-tags-present
branch
10 times, most recently
from
32ee1c9
to
99432e5
Compare
When there are commits but no tags, then insert those commits under the unreleased section of the change log output. This requires get an updated CHANGELOG.md.tpl file. Includig the template footer to account for the unreleased line there that used .Versions. resolves git-chglog#76 BREAKING CHANGE: * No longer throw the error "no tags" when: * No tag query entered * There are commits to tag * Requires an update to the changelog template
b01
force-pushed
the
issue-76-enhancement-when-no-tags-present
branch
from
99432e5
to
175b6f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
When there are commits and no existing git tags, add any notable changes to the "Unreleased" section of the change log.
This requires is a breaking change because
git-chglog --initExisting template will still work.
How this PR fixes the problem?
In the
chglog.gofile some function have been update so that if the code cannot find any tag and there is no value set for "nexttag" or in the query, then allow a CHANGLOG.md to get generated. The template has been updated to alllow the "Unreleased" section to be displayed even when no previous versions exist.Changed the code in several places so that when there is no tag query set, then continue program execution, even if no tags are found. Thus removing the "no tags" error, if any programs parsed that error they will break. This allows unreleased commits from the beginning of he repositories history to be collected.
In addition, the templates had to be modified to allow adding the unreleased sections independent of versions. Since there will be no versions, as implied when there are no tags.
What should your reviewer look out for in this PR?
Check lists
Additional Comments (if any)
Again, I am proposing this BREAKING CHANGE, which is that the program will never show the no tags error message again. The closes a PR that changes that message.
Which issue(s) does this PR fix?
fixes #76
closes #187