Add support for named networks #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to define `-n <network_name>` to create the VM attached to that network
Allow to define `-n <network_name>` to create the VM attached to that network
Following suggestion from 22-Oct-2019 in stale PR giovtorres#43 to upstream fork
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resurrects an earlier closed one (#43), which added the
-nparameter to allow attaching of VMs to defined libvirt networks at creation. I have just rebased that PR on top of the latestmasterbranch, and added the last suggestion from the discussion on PR #43 about the bridge extraction command.It's working for my needs! Happy to take on any further comments that would see it merged back upsteam.