Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-routable option not working #102

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

simmonsr
Copy link

When selecting Routable: disabled with Antimatter, it has no effect. The following change fixes the issue.

When selecting Routable: disabled with Antimatter, it has no effect. The following change fixes the issue.
@rhukster
Copy link
Member

I can see the issue that a routable page (should be in menu, can't reach the page) could be handled better in Antimatter (all themes probably), but I think it can be done with a lot less copy/paste style code. In fact a non-routable page should have no <a> at all, and should use a <span>, but these means some tweaks to the scss also.

@simmonsr
Copy link
Author

simmonsr commented Mar 28, 2017

I can just create an issue for the theme if you would prefer. Currently Routable: Disabled simply does not work w/ antimatter. It continues to be routable.

But yes, I agree it should use span and if there is smoother option than great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants