Docker extension #443
Draft
Docker extension #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cehbrecht
requested changes
Dec 20, 2018
| @@ -172,20 +173,32 @@ def _execute_process(self, async, wps_request, wps_response): | |||
| if running >= maxparallel and maxparallel != -1: | |||
| raise ServerBusy('Maximum number of parallel running processes reached. Please try later.') | |||
| wps_response._update_status(WPS_STATUS.ACCEPTED, u"PyWPS Request accepted", 0) | |||
| wps_response = self._run_process(wps_request, wps_response) | |||
| wps_response = self._run_sync(wps_request, wps_response) | |||
There was a problem hiding this comment.
why is it called run_sync? docker will only be run in async mode.
There was a problem hiding this comment.
We discussed that with @jachym and we concluded that the docker should be run even in sync mode once the mode parameter is set to docker in config file.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added new
Container.pyclass for Docker extension.The extension works so far only for pywps-flask demo server. See pywps-flask PR.
Related Issue / Discussion
Additional Information
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)