Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated mopad.py to python3 compatible with 2to3 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cossatot
Copy link

Hey y'all, I've converted MoPaD to python 3 compatibility. Thanks for making the awesome tool!

@cossatot cossatot mentioned this pull request Mar 19, 2015
@QuLogic
Copy link

QuLogic commented Mar 22, 2015

If you're going to use the print function, then you should from __future__ import print_function, or else you'll get the issue that resulted in the second commit here.

@cossatot
Copy link
Author

Yeah, I understand the problem. I didn't closely inspect the output from 2to3 before committing; I expected 2to3 to automatically produce code that would be compatible with both. Nonetheless, getting rid of the end=' 's still cleans things up a bit.

@QuLogic
Copy link

QuLogic commented Mar 23, 2015

Yes, but I mean you should add it anyway. Unless you're aiming for compatibility with Python 2.5 (which is ancient), there's no reason not to do so, and it will reduce the chance of the same confusion occurring with some other developer later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants