Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow / Edit action / Fix link in search results #8031

Merged
merged 1 commit into from
May 16, 2024

Conversation

fxprunayre
Copy link
Member

Follow up of #6321

image

This was noticed because then when an approved record is found, the edit action in the search result page was opening the editor with a link http://localhost:8080/geonetwork/srv/eng/catalog.edit#/metadata/ApprovedID

Then the editor was opening the editor form with the UUID.

And in such case the editor does not do the redirection (in MetadataEditingApi.java#L153).

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Follow up of #6321

This was noticed because then when an approved record is found, the edit
action in the search result page was opening the editor with a link
http://localhost:8080/geonetwork/srv/eng/catalog.edit#/metadata/ApprovedID

Then the editor was opening the editor form with the UUID.

And in such case the editor does not do the redirection (in
MetadataEditingApi.java#L153).
@fxprunayre fxprunayre added this to the 4.4.5 milestone May 13, 2024
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@joachimnielandt joachimnielandt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works fine.

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine.

@josegar74 josegar74 merged commit 9e4b7ec into main May 16, 2024
10 checks passed
joachimnielandt pushed a commit to Informatievlaanderen/metadata-geonetwork that referenced this pull request May 28, 2024
    Follow up of geonetwork#6321

    This was noticed because then when an approved record is found, the edit
    action in the search result page was opening the editor with a link
    http://localhost:8080/geonetwork/srv/eng/catalog.edit#/metadata/ApprovedID

    Then the editor was opening the editor form with the UUID.

    And in such case the editor does not do the redirection (in
    MetadataEditingApi.java#L153).

GN ref geonetwork#8031

Related work items: #189418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants