Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor / Table mode / Add ordering control. #8016

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

fxprunayre
Copy link
Member

Add possibility to enable ordering control in table mode.

image

Refactor templates to use the same for all plugins.

Also stop event propagation to avoid to collapse a fieldset when moving such elements.

Fix visibility of icons depending on position.

Funded by Ifremer.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

Add possibility to enable ordering control in table mode.

Refactor templates to use the same for all plugins.

Also stop event propagation to avoid to collapse a fieldset when moving
such elements.

Fix visibility of icons depending on position.

Funded by Ifremer.
@fxprunayre fxprunayre added this to the 4.4.5 milestone May 6, 2024
@fxprunayre fxprunayre requested a review from josegar74 May 6, 2024 11:59
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine

@josegar74 josegar74 merged commit 83b1ab3 into main May 17, 2024
10 checks passed
@fxprunayre fxprunayre deleted the 44-editortablewithorder branch May 17, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants