Standard / ISO19115-3 / Avoid indexing error on multilingual feature catalogue #8013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…catalogue On the long run, we need to add multilingual support here.
josegar74
reviewed
May 16, 2024
| "code" :"<xsl:value-of select="util:escapeForJson(gfc:FC_FeatureType/gfc:code/*/text())"/>", | ||
| "isAbstract" :"<xsl:value-of select="gfc:FC_FeatureType/gfc:isAbstract/*/text()"/>", | ||
| "aliases" : "<xsl:value-of select="util:escapeForJson(gfc:FC_FeatureType/gfc:aliases/*/text())"/>" | ||
| "definition" :"<xsl:value-of select="util:escapeForJson(gfc:FC_FeatureType/gfc:definition/gco:CharacterString/text())"/>", |
There was a problem hiding this comment.
Should not be (gco:CharacterString|gcx:Anchor)?
There was a problem hiding this comment.
I've never seen Anchor used in here. If putting a link to a document for the feature type, it would go in definitionReference I suppose
<gfc:featureType>
<gfc:FC_FeatureType>
<gfc:typeName/>
<gfc:definition gco:nilReason="missing" xsi:type="lan:PT_FreeText_PropertyType">
<gco:CharacterString/>
</gfc:definition>
<gfc:isAbstract>
<gco:Boolean>true</gco:Boolean>
</gfc:isAbstract>
<gfc:aliases/>
<gfc:definitionReference>
<gfc:FC_DefinitionReference>
<gfc:definitionSource>
<gfc:FC_DefinitionSource>
<gfc:source>
<cit:CI_Citation>
<cit:title gco:nilReason="missing" xsi:type="lan:PT_FreeText_PropertyType">
<gco:CharacterString/>
<lan:PT_FreeText>
<lan:textGroup>
<lan:LocalisedCharacterString locale="#FR"/>
</lan:textGroup>
<lan:textGroup>
<lan:LocalisedCharacterString locale="#EN">Data model published by the Sandre</lan:LocalisedCharacterString>
</lan:textGroup>
</lan:PT_FreeText>
</cit:title>
<cit:onlineResource>
<cit:CI_OnlineResource>
<cit:linkage xsi:type="lan:PT_FreeText_PropertyType">
<gco:CharacterString/>
<lan:PT_FreeText>
<lan:textGroup>
<lan:LocalisedCharacterString locale="#FR">https://www.sandre.eaufrance.fr/definition/eth/latest</lan:LocalisedCharacterString>
</lan:textGroup>| "aliases" : "<xsl:value-of select="util:escapeForJson(gfc:FC_FeatureType/gfc:aliases/*/text())"/>" | ||
| "definition" :"<xsl:value-of select="util:escapeForJson(gfc:FC_FeatureType/gfc:definition/gco:CharacterString/text())"/>", | ||
| "code" :"<xsl:value-of select="util:escapeForJson(gfc:FC_FeatureType/gfc:code/(gco:CharacterString|gcx:Anchor)/text())"/>", | ||
| "isAbstract" :"<xsl:value-of select="gfc:FC_FeatureType/gfc:isAbstract/gco:CharacterString/text()"/>", |
There was a problem hiding this comment.
Should not be (gco:CharacterString|gcx:Anchor)?
There was a problem hiding this comment.
In fact this should be gco:Boolean. Fixed.
| "definition" :"<xsl:value-of select="util:escapeForJson(gfc:FC_FeatureType/gfc:definition/gco:CharacterString/text())"/>", | ||
| "code" :"<xsl:value-of select="util:escapeForJson(gfc:FC_FeatureType/gfc:code/(gco:CharacterString|gcx:Anchor)/text())"/>", | ||
| "isAbstract" :"<xsl:value-of select="gfc:FC_FeatureType/gfc:isAbstract/gco:CharacterString/text()"/>", | ||
| "aliases" : "<xsl:value-of select="util:escapeForJson(gfc:FC_FeatureType/gfc:aliases/gco:CharacterString/text())"/>" |
There was a problem hiding this comment.
Should not be (gco:CharacterString|gcx:Anchor)?
There was a problem hiding this comment.
Same, never seen usage of Anchor in here.
|
josegar74
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test, create a record with feature catalogue and add more than one language.
On the long run, we need to add multilingual support here.
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation