Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development environment updates for geonetwork 4 #7955

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jodygarnett
Copy link
Contributor

A few of the steps described in starting up with docker did not work as expected; also updated IntellIJ steps and profiles based on discussion with @josegar74.

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@josegar74 josegar74 changed the title development enviornment updates for geonetwork 4 Development environment updates for geonetwork 4 Apr 16, 2024
@fxprunayre
Copy link
Member

Looks ok @jodygarnett but just sharing some feedback on this topic:

  • Using env-dev long long time ago, I always found it quite slow (and working with others on windows, it can be even terribly slow ...).
  • For UI - JS and HTML change, using ?debug URL parameter is fast and good enough
  • For UI - JS dependency tree change or CSS, clean the cache from the admin is working fine
  • For XSL, the cache is invalidated once you change the main XSL file (it is not invalidated when changing an imported one). Using a trigger to touch the files you're working one can be quick and simple. eg. while working on the editor, I'm using this which copy plugins and touch editor related XSLT
current=`pwd`
echo "Copy schemas in $current"
cd schemas
for d in *; do
 if [ -d "$d/src/main/plugin/$d" ]; then
   echo $d
   rm -fr ../web/src/main/webapp/WEB-INF/data/config/schema_plugins/$d
   cp -fr $d/src/main/plugin/$d ../web/src/main/webapp/WEB-INF/data/config/schema_plugins/.
 fi
done
cd ..
touch web/src/main/webapp/xslt/ui-metadata/edit/edit.xsl
touch web/src/main/webapp/xslt/services/thesaurus/convert.xsl
touch web/src/main/webapp/xslt/services/subtemplate/convert.xsl

Then there is other specific cases eg. working with schematron

So I'm not sure what is the best approach to recommend. Relying on maven profiles and command is for sure cleaner but somehow less efficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants