Test SRV quotient metric on shapes of objects #1934
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1934 +/- ##
==========================================
+ Coverage 87.30% 90.44% +3.14%
==========================================
Files 143 142 -1
Lines 13626 12916 -710
==========================================
- Hits 11895 11680 -215
+ Misses 1731 1236 -495
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@luisfpereira @MMalikT @ninamiolane This PR starts a notebook that should ultimately become the new version of the shape analysis notebook. The data come from https://2dshapesstructure.github.io/. The goal is to showcase the tools of shape analysis on examples where we can visually evaluate the result (how credible is the geodesic between two birds or two dogs?). These simple examples can serve as benchmark to evaluate the alignment methods. We can already see that dynamic programming performs better than the other aligner, and we should probably focus our efforts on that method, making it work well on closed curves.
The PR also removes the Euler step in the iterative horizontal geodesic algorithm and replaces it with a sort.