init mp calculate 1 #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BonfaceKilz
requested changes
Jan 22, 2022
There was a problem hiding this comment.
@Alexanderlacuna I've added some comments for you to work on-- shouldn't be alot of work; and then I'll have this merged ASAIC.
Comment on lines
+428
to
+430
| def compute_correlation_2(corr_inputs): | ||
|
|
||
| (this_trait_samples, target_trait) = corr_inputs |
There was a problem hiding this comment.
issue: pass in samples and target_traits as params; instead of a single set. The resulting function should look like:
Suggested change
| def compute_correlation_2(corr_inputs): | |
| (this_trait_samples, target_trait) = corr_inputs | |
| def compute_correlation_2(samples, target_trait): |
| (corr_coeff, p_val) = scipy.stats.pearsonr( | ||
| x_vals[~nans_values], y_vals[~nans_values]) | ||
|
|
||
| # print(corr_coeff, p_val) |
There was a problem hiding this comment.
nitpick: Remove this dead comment.
| credit:https://github.com/bukson/nancorrmp | ||
|
|
||
| """ | ||
| this_trait_samples = this_trait["trait_sample_data"] |
There was a problem hiding this comment.
nitpick: You should really work on how you name your variables. Stop inheriting this naming scheme from gn2. Try to use variables that are easy to understand when scheming code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation Parallel correlation calculation of big numpy arrays or pandas dataframes with NaNs and infs
for gn3
Credit:https://github.com/bukson/nancorrmp