Changes to sample data editing

[zsloan]

This PR will make a couple changes to sample data editing:

• Values will be editable for samples that don't currently have values. Currently you can only edit sample values for samples that already have values; this is because it just pulls the sample data from the DB and wasn't accounting for the sample list
• It will be possible to submit sample data changes via an HTML table, instead of just as a CSV import

The corresponding GN3 PR is here - genenetwork/genenetwork3#117

[BonfaceKilz]

Minor comments; otherwise this LGTM.

[BonfaceKilz]

question: issue: This seems odd to me. Doing a string comparison the string "false". If there's a way to do directly with a boolean value, it would make this easier to both debug and read.

[jgarte]

Hi @zsloan @BonfaceKilz, maybe there's a way to code this that doesn't have a high cyclomatic complexity?

Otherwise, #781 LGTM

Feel free to ignore if you think this is a nitpick...

[zsloan]

I also really don't like how those nested for loops work, but I'm not sure how else to do them. The original version of the code didn't have this problem because it only needed to care about samples with values (which would be the same in both the base and delta CSV files) and also had the CSV directly submitted instead of specific values being submitted through a form. Basically what needs to happen is for a CSV string to be written that is essentially the base_csv but with values substituted when they were edited (what it's getting from the form). So it goes through each line and checks if edits of the value, error, or n_cases were submitted with the form. It could maybe be made a bit more simple by converting all the edits into a single JSON value either before or after being submitted with the form, though this would also require more code and it would still need to check "do edits exist" for each sample/row. I think this would only circumvent the "if form_data.get()" checks.

…

On Fri, May 12, 2023, 10:46 AM jgart ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In wqflask/wqflask/metadata_edits.py <#781 (comment)> : > @@ -705,3 +727,26 @@ def approve_data(resource_id: str, file_name: str): "warning", ) return redirect(url_for("metadata_edit.list_diffs")) + +def create_delta_csv(base_csv, form_data, sample_list): + base_csv_lines = base_csv.split("\n") + delta_csv_lines = [base_csv_lines[0]] + + for line in base_csv_lines[1:]: Hi, maybe there's a way to code this that doesn't have such a high cyclomatic ***@***.***/python-code-complexity-metrics-e6c87646c1c2> complexity? Otherwise #781 <#781> LGTM — Reply to this email directly, view it on GitHub <#781 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANQJGAS7VMFUMFLOQQCN4LXFZLMDANCNFSM6AAAAAAX6Q4CWE> . You are receiving this because you were assigned.Message ID: ***@***.***>