Correlations: Select top n results at the very end
#750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filter the correlation results before selecting the top `n` results to avoid the scenario where less than `n` results are returned. * wqflask/wqflask/correlation/rust_correlation.py: remove `top_n` and `n_top` arguments from function no longer needing them. * wqflask/wqflask/correlation/show_corr_results.py: Select top `n` results at the very end, at output.
fredmanglis
force-pushed
the
testing
branch
2 times, most recently
from
04f10df
to
5474e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filter the correlation results before selecting the top
nresults to avoid the scenario where less thannresults are returned.top_nandn_toparguments from function no longer needing them.nresults at the very end, at output.This pull request relies on this other pull request