Feature/add trait columns #748
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to clear new column headers, but I need to change it so that it only does it when adding new columns
Otherwise the row data is effectively deleted. This was initially done because it appears to be the only way to add columns to an existing data table that uses Scroller.
This also changes the way columns are added; previously a list of new columns was passed to the table generation code, but now I just add them to the attribute data in js_data The main remaining feature to add is the ability to remove columns (which I'll probably do as just the ability to remove all columns; I'm not sure how to reasonable add the option to remove specific columns)
|
Very cool. Excited to test. Thanks.
…On Thu, Nov 17, 2022 at 3:57 PM zsloan ***@***.***> wrote:
This PR adds the option to add traits from a collection as extra
pseudo-"case attribute" columns on the trait page.
The user can then filter off of those columns just like off of normal case
attribute columns
------------------------------
You can view, comment on, or merge this pull request online at:
#748
Commit Summary
- 7aa792b
<7aa792b>
Create button for adding traits to table
- e710c91
<e710c91>
Destroy/empty table before creation
- 6651900
<6651900>
Add JS for adding traits to table
- 8995c0c
<8995c0c>
Only empty table container on loading if data is loaded from JSON
- 1db2834
<1db2834>
Make Transform/Filter options work with added trait columns
File Changes
(5 files <https://github.com/genenetwork/genenetwork2/pull/748/files>)
- *A* wqflask/wqflask/static/new/javascript/add_traits_to_table.js
<https://github.com/genenetwork/genenetwork2/pull/748/files#diff-d0479702a81593994d84e2bf303e921dbf8627fa9c9970933fc14c9ba9d0eabc>
(300)
- *M* wqflask/wqflask/static/new/javascript/create_datatable.js
<https://github.com/genenetwork/genenetwork2/pull/748/files#diff-1393bb3fb2ef209a1982ade89b132b1fb97ebf0f80dc37202dd40ad37249a30a>
(5)
- *M*
wqflask/wqflask/static/new/javascript/initialize_show_trait_tables.js
<https://github.com/genenetwork/genenetwork2/pull/748/files#diff-09ae307d0488a7dc7c9eedd7c6e897e363857f650a6cb73933f6e1a8cb6e1f8a>
(331)
- *M* wqflask/wqflask/static/new/javascript/show_trait.js
<https://github.com/genenetwork/genenetwork2/pull/748/files#diff-3edfd5623c8d344941dcfe7356a4d540334f4c6c67ff97a47a82e6c1f8abd9f9>
(11)
- *M* wqflask/wqflask/templates/show_trait_edit_data.html
<https://github.com/genenetwork/genenetwork2/pull/748/files#diff-d63ef77225a78bad48e2b78087202866123fa9a10ae112a7e660079520c6b4ec>
(2)
Patch Links:
- https://github.com/genenetwork/genenetwork2/pull/748.patch
- https://github.com/genenetwork/genenetwork2/pull/748.diff
—
Reply to this email directly, view it on GitHub
<#748>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC55V7HJLBVUGYHOYGQYAGLWI2S3XANCNFSM6AAAAAASD3B3NU>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Rob
Robert W Williams PhD
Department of Genetics, Genomics and Informatics
71 S Manassas St, Memphis TN 38163
University of Tennessee Health Science Center, TSRB 405
Cell: 901 604 4752
EMAIL: ***@***.***
Zoom: https://tennesseehipaa.zoom.us/j/9492269658
----------------
|
|
It isn't on production yet, but it is on my branch right now.
The option to remove added columns doesn't exist yet (and when I do add it,
it'll probably just be the option to remove all added columns, since doing
it for specific ones will greatly complicate things), but the transform
functions should work.
One complication (that shouldn't be hard to address, but need to decide
how) is the existence of x values. Currently it just completely ignores all
samples like that. Probably easier to just show what I'm talking about, so
I'll do that tomorrow morning.
…On Thu, Nov 17, 2022, 4:12 PM Rob Williams ***@***.***> wrote:
Very cool. Excited to test. Thanks.
On Thu, Nov 17, 2022 at 3:57 PM zsloan ***@***.***> wrote:
> This PR adds the option to add traits from a collection as extra
> pseudo-"case attribute" columns on the trait page.
>
> The user can then filter off of those columns just like off of normal
case
> attribute columns
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #748
> Commit Summary
>
> - 7aa792b
> <
7aa792b
>
> Create button for adding traits to table
> - e710c91
> <
e710c91
>
> Destroy/empty table before creation
> - 6651900
> <
6651900
>
> Add JS for adding traits to table
> - 8995c0c
> <
8995c0c
>
> Only empty table container on loading if data is loaded from JSON
> - 1db2834
> <
1db2834
>
> Make Transform/Filter options work with added trait columns
>
> File Changes
>
> (5 files <https://github.com/genenetwork/genenetwork2/pull/748/files>)
>
> - *A* wqflask/wqflask/static/new/javascript/add_traits_to_table.js
> <
https://github.com/genenetwork/genenetwork2/pull/748/files#diff-d0479702a81593994d84e2bf303e921dbf8627fa9c9970933fc14c9ba9d0eabc
>
> (300)
> - *M* wqflask/wqflask/static/new/javascript/create_datatable.js
> <
https://github.com/genenetwork/genenetwork2/pull/748/files#diff-1393bb3fb2ef209a1982ade89b132b1fb97ebf0f80dc37202dd40ad37249a30a
>
> (5)
> - *M*
> wqflask/wqflask/static/new/javascript/initialize_show_trait_tables.js
> <
https://github.com/genenetwork/genenetwork2/pull/748/files#diff-09ae307d0488a7dc7c9eedd7c6e897e363857f650a6cb73933f6e1a8cb6e1f8a
>
> (331)
> - *M* wqflask/wqflask/static/new/javascript/show_trait.js
> <
https://github.com/genenetwork/genenetwork2/pull/748/files#diff-3edfd5623c8d344941dcfe7356a4d540334f4c6c67ff97a47a82e6c1f8abd9f9
>
> (11)
> - *M* wqflask/wqflask/templates/show_trait_edit_data.html
> <
https://github.com/genenetwork/genenetwork2/pull/748/files#diff-d63ef77225a78bad48e2b78087202866123fa9a10ae112a7e660079520c6b4ec
>
> (2)
>
> Patch Links:
>
> - https://github.com/genenetwork/genenetwork2/pull/748.patch
> - https://github.com/genenetwork/genenetwork2/pull/748.diff
>
> —
> Reply to this email directly, view it on GitHub
> <#748>, or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AC55V7HJLBVUGYHOYGQYAGLWI2S3XANCNFSM6AAAAAASD3B3NU
>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
--
Rob
Robert W Williams PhD
Department of Genetics, Genomics and Informatics
71 S Manassas St, Memphis TN 38163
University of Tennessee Health Science Center, TSRB 405
Cell: 901 604 4752
EMAIL: ***@***.***
Zoom: https://tennesseehipaa.zoom.us/j/9492269658
----------------
—
Reply to this email directly, view it on GitHub
<#748 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANQJGCMMZD2VWMCO7PHCITWI2UWRANCNFSM6AAAAAASD3B3NU>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
fredmanglis
force-pushed
the
testing
branch
2 times, most recently
from
04f10df
to
5474e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to add traits from a collection as extra pseudo-"case attribute" columns on the trait page.
The user can then filter off of those columns just like off of normal case attribute columns