Redo collection table to be built in the same way as search results #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
table This completely redoes the way the collection table is built to bring it more in line with the search results table A lot of code is duplicated for this, so this needs to be looked at some more to try and simplify things.
fredmanglis
force-pushed
the
testing
branch
2 times, most recently
from
04f10df
to
5474e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redoes the collection table to make it more similar to the search results table (which includes stuff like adding the option to manually adjust column widths).
At some point this code needs to be shared between all features that generated tables of traits, but I'm not sure how best to do this.