Fix CSV Download link #665
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the CSV Download link to take the inbred_set_id (group ID) as a parameter, instead of the phenotype ID. There are corresponding changes to GN3 to account for this as well.
fredmanglis
force-pushed
the
testing
branch
2 times, most recently
from
04f10df
to
5474e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just changes the CSV download link in edit_phenotype.html to take the inbred_set_id as a parameter instead of phenotype ID (since the combination of PublishXRef.Id and PublishXRef.InbredSetId is the best way to identify a trait). There's a separate GN3 PR changing the query on that end.