Feature/add mapping endpoints #529
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexanderlacuna
force-pushed
the
feature/add-mapping-endpoints
branch
from
57f4457
to
060ae33
Compare
|
We actually don't need an endpoint for Plink, by the way (it was basically made obsolete by GEMMA). I'm also making some changes that will probably be relevant to the get_loading_page_data function (and maybe some other places) here - #535 Currently sample data is passed as a bunch of separate inputs (where it says "if key in wanted or key.startswith(('value:'))" in the code - currently there are separate inputs with names like "value:BXD1", "value:BXD2", etc), and this PR changes the sample values to be passed as JSON instead. |
fredmanglis
force-pushed
the
testing
branch
2 times, most recently
from
04f10df
to
5474e66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update /run_mapping and /loading in wqflask/views.py to have each mapping on own path
How should this be tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Questions