Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vertical Component to Abrahamson_Silva 1997 #9658

Merged
merged 9 commits into from
May 22, 2024

Conversation

FatemehAlsh
Copy link
Contributor

@FatemehAlsh FatemehAlsh commented May 12, 2024

The "abrahamson_silva_1997" gsim library is updated to compute vertical component too.
The following changes are made:
1- A new class for vertical component is added to 'abrahamson_silva_1997' gsim.
2- The test file of "abrahamson_silva_1997_test" is updated so that is includes the tests related to vertical component.
3- 3 new verification tables of vertical component are added to hazardlib/tests/gsim/data/AS97. The verification tables are
obtained using EZ_FRisk.

The vertical component of attenuation model of Abrahamson_Silva_1997 is added.
The tests of vertical component of the model is added.
The verification tables of vertical components of abrahamson_silva_1997 is added.
The name of the contributor was at the top of the list by a mistake, it is put at the end of the list now.
Fatemeh added vertical component to AS97
@micheles micheles added this to the Engine 3.20.0 milestone May 12, 2024
@micheles micheles requested a review from mmpagani May 12, 2024 14:10
Copy link
Member

@mmpagani mmpagani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

Fatemeh added vertical component to AS97
@micheles micheles merged commit 96b8a47 into gem:master May 22, 2024
6 checks passed
@FatemehAlsh FatemehAlsh deleted the gsim_AS97Vertical_BZP branch May 22, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants