AELO year 3 updates to run all IMTs #9648
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheles
reviewed
May 13, 2024
| IMTS = ['PGA', 'SA(0.02)', 'SA(0.03)', 'SA(0.05)', 'SA(0.075)', 'SA(0.1)', | ||
| 'SA(0.15)', 'SA(0.2)', 'SA(0.25)', 'SA(0.3)', 'SA(0.4)', 'SA(0.5)', | ||
| 'SA(0.75)', 'SA(1.0)', 'SA(1.5)', 'SA(2.0)', 'SA(3.0)', 'SA(4.0)', | ||
| 'SA(5.0)', 'SA(7.5)', 'SA(10.0)'] |
There was a problem hiding this comment.
I thought most GMPEs could not be extended to SA(10.0) and we decided to discard it (?)
There was a problem hiding this comment.
We have now updated so that the IMTS are defined in the job file, instead of using defaults
AnnaRood
changed the title
micheles
reviewed
May 14, 2024
| @@ -115,7 +110,9 @@ def calc_rtgm_df(hcurves, site, site_idx, oq): | |||
| :returns: pandas dataframe with RTGM and related parameters | |||
| :returns: numpy array of conversion factors to max component | |||
| """ | |||
| IMTS = list(oq.imtls) | |||
There was a problem hiding this comment.
The conventions is to use all caps for constants, so IMTS is a bad name. You can use imts or job_imts or orig_imts or whatever you like more.
"merging asce from master"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated AELO Year 1 IMTs [PGA, SA(0.2), and SA(1.0)] to run Year 3 [PGA, SA(0.02) -> SA(10)].
[Note: no SA(0) yet]
Updated to ASCE7-22 parameters.
Plots updated to show: