Complex Fault Refactoring #9280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally (without changing delta)
…ally (without changing delta)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we are replacing the original sampling method with the the new one implemented in the
linemodule. This new approach introduces slight differences in the geometries of the surfaces generated but - overall - the results appear consistent with the original ones.Note that several QA tests pass locally but require increased tolerance when executed on the remote machine.
The disaggregation QA test 7 shows slightly larger differences between the hazard computed with the previous and current sampling methods. This depends on the fact that the site is on one side of the two subduction sources used and the new sampling algorithm creates a slightly shorter mesh. See the figure below where the blue dots show the new mesh and the pink dots are the old one. The point in yellow is the site.