-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prettier formatter #1736
base: master
Are you sure you want to change the base?
Add prettier formatter #1736
Conversation
"no-whitespace-before-property": "error", | ||
"operator-linebreak": ["error", "after"], | ||
"operator-linebreak": ["error", "before"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed operator-linebreak
to before
to go along with prettier formatting
- name: Format & Lint | ||
run: (npm run style || npm run lint) && git diff --exit-code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified pull_request workflow to include prettier formatting. These checks cannot be made individually in separate steps because it changes the files. Hence doing it together and checking for any file changes
options: { | ||
fix: true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added option to fix any linting errors
I'm relatively concerned by the number of files changed by this PR. If I merge it, this will cause merge conflicts with the vast number of other PRs that are available right now. I wonder if, perhaps, it's best to wait for me to try to process all of those and then do a single large 'style' pull request. As a side note, you probably want to not style |
Fixes #1726 Added prettier as per the GitHub Issue conversation