Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/theme config #2665

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Feature/theme config #2665

wants to merge 8 commits into from

Conversation

jmgroud
Copy link

@jmgroud jmgroud commented Jun 21, 2020

Hello
I want to create a new theme, for example from "Helium" to "NewTheme". By reading the documentation on this link ...
[http://docs.gantry.org/gantry5/theme-development/change-theme-name]
... I ask myself the following question: is it really necessary to modify absolutely ALL the character strings "Helium" by "NewTheme" in all text files? For example in the file "templateDetails.xml" is it not dangerous to modify the lines:

<server type = "extension" priority = "1" name = "**Helium** Template"> http://updates.gantry.org/5.0/joomla/tpl_g5_**helium**.xml </server>

by

<server type = "extension" priority = "1" name = "**NewTheme** Template"> http://updates.gantry.org/5.0/joomla/tpl_g5_**newtheme**.xml </server>

Are there other specific places where you have to be careful not to change these values?
If there is danger, perhaps it would be interesting to indicate it in the chapter "STEP 3" of the documentation ...

@mahagr
Copy link
Member

mahagr commented Jul 8, 2020

Not sure why you ended up doing a pull request against a branch which isn't finished.

You're right, that line should be removed instead of updated, but it's not really dangerous to leave it be as the call will most likely fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants