filter hidden menu items #2398
Open
filter hidden menu items #2398
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any news on this? It's been a year since I opened it. Joomla's mod_menu is doing something similar in it's mod_menu/helper.php where this method original comes from. Maybe it's better to just port everything from there over? |
|
The check should not be in this level, the same code is used in admin to edit pages. Our code is delivered from some older version (J3.4 I think) of Joomla helper class and template file. I will need to take a look into this as I'm currently removing support for older Joomla versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another approach to the issue I've tried to fix in #2348, but this will only affect Joomla.
It will change the menu editor behavior slightly, because hidden menu items won't show up anymore.
But that's the same for the editor in Grav.