DOMSubtreeModified deprecation fix

gantry · Sep 29, 2023 · 7519e3d · 7519e3d
1 parent 2796588
commit 7519e3d
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/assets/common/application/offcanvas/index.js b/assets/common/application/offcanvas/index.js
@@ -126,9 +126,12 @@ var Offcanvas = new prime({
     },
 
     attachMutationEvent: function() {
-        this.offcanvas.on('DOMSubtreeModified', this.bound('_checkTogglers')); // IE8 < has propertychange
+        if (this.offcanvas instanceof Node) {
+            var observer = new MutationObserver(this.bound('_checkTogglers'));
+            observer.observe(this.offcanvas, { childList: true, subtree: true });
+        }
     },
-
+    
     attachTouchEvents: function() {
         var msPointerSupported = window.navigator.msPointerEnabled,
             touch              = {
@@ -164,9 +167,12 @@ var Offcanvas = new prime({
     },
 
     detachMutationEvent: function() {
-        this.offcanvas.off('DOMSubtreeModified', this.bound('_checkTogglers'));
+        if (this.offcanvas instanceof Node) {
+            var observer = new MutationObserver(this.bound('_checkTogglers'));
+            observer.disconnect();
+        }
     },
-
+    
     detachTouchEvents: function() {
         var msPointerSupported = window.navigator.msPointerEnabled,
             touch              = {

diff --git a/assets/common/js/main.js b/assets/common/js/main.js
diff --git a/gulpfile.js b/gulpfile.js
@@ -234,8 +234,11 @@ var minifyJS = function() {
     return merge(streams);
 };
 
-function minify() {
-    if (!prod) { return; }
+function minify(done) {
+    if (!prod) { 
+        done();
+        return; 
+    }
 
     return minifyJS();
 }