Chapter 5.3, fixed wrong paths, added ref to custom overrides #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thexmanxyz
changed the title
|
@marktaylor46 @RyanMPierson Tagging people! Please merge ASAP as this mistake is a very confusing one for users! |
|
you should add |
|
@simmonsr I deleted now my previous comment, you are totally right, I will now adapt the path for Grav. For Joomla and WP the paths are also starting in the root directory of the CMS. I thought they weren't. I will add a commit soon. Moreover I will now also add a reference on chapter 5.6 so that users can directly jump to the file overrides chapter were everything concerning override paths is explained. I think this is useful and should be outlined in chapter 5.3 as well. |
thexmanxyz
changed the title
thexmanxyz
force-pushed
the
bug/5-3docs_path
branch
from
0b803a5
to
c7bd2ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I noticed a typo concerning the Grav path for
enginefiles under 5.3.Please see the first screenshot which shows the section with the error (located here) as well as the second screenshot with the correct path (located here).
Please carefully compare it with the file overrides chapter.
Wrong Path (5.3):
Correct Path (5.6):
Thanks and credits to @ChrystalSolutions who noticed the error as well.
Edit: Additionally I fixed some path inconsistencies and added a reference to chapter 5.6