reallow dc390 scsi card emulation choice with kvm #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbat2
approved these changes
Jun 22, 2022
|
Hi @ksanislo, could you rebase the patch on the current master and force-push it to your branch/fork? That would make automated testing easier. Thanks :-) |
ksanislo
force-pushed
the
tekram_dc390_scsi
branch
from
3c1d1f6
to
52e22f8
Compare
|
@rbott I've rebased my branch. Let me know if you need anything else, thanks! |
|
This branch works fine against QA suite. I'll do some more tests and then will move forward and merge it if nothing serious happens :-) (sorry for the delay!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the advent of ganeti 2.16's revamped scsi configuration, we lost the previous ability to configure a VM with a scsi card as 'dc390' through the use of the kvm_extra parameter alone.
I have existing legacy production infrastructure deployed via freebsd (3.x and 4.x) on ganeti which requires this SCSI card to operate. I would like to have the 'dc390' card put back in as a fully fledged scsi card choice that can be configured in the proper manner.