Implement Map broadcasting #3570
Open
+199
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3570 +/- ##
==========================================
- Coverage 93.87% 93.86% -0.02%
==========================================
Files 159 159
Lines 19216 19243 +27
==========================================
+ Hits 18039 18062 +23
- Misses 1177 1181 +4
Continue to review full report at Codecov.
|
|
@adonath what is the status here? |
|
@registerrier No, I think this will require more discussion on the actual behavior. E.g. if positions of axes do not align etc. Let's postpone... |
|
Hi @adonath . What is the status here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements the support for broadcasting when doing map arithmetics. It include the following methods:
MapAxis.broadcast(), which returns the broadcasted axis dimension, i.e. the max of the len of the axis, when either both axes are equal or one of them has exactly one bin.MapAxes.broadcast(), which follow bumpy broadcasting rules.Geom.broadcast(), does broadcasting of the extra axes and requires the spatial dimension to be equivalent.Dear reviewer
Todo:
maps.ipynbtutorial