Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Azure storage infrastructure. #18087

Merged
merged 1 commit into from May 6, 2024

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented May 2, 2024

  • Upgrade away from legacy Azure APIs for azure_blob object store. Eliminate some hacks and fix a bunch of things I discovered during testing. I also think these have been broken since the object store selection PR was merged years ago at this point 馃槄.
  • Implement short-term read-only tokens for azure storage blobs.
  • Implement an Azure file source using the relevant pyfilesystem plugins. I don't love everything the plugin implementation does but I guess we should assume they did it that way for a reason.
  • A lot more testing for the object store ("unit" testing that tests the unit against actual APIs if you have keys and integration with the rest of Galaxy) and some initial testing for the new file source plugins.

How to test the changes?

(Select all options that apply)

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jmchilton jmchilton marked this pull request as ready for review May 4, 2024 21:14
@github-actions github-actions bot added this to the 24.1 milestone May 4, 2024
@mvdbeek mvdbeek merged commit 4f68dd2 into galaxyproject:dev May 6, 2024
54 of 55 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented May 6, 2024

Thank you @jmchilton!

@nsoranzo nsoranzo deleted the rev_azure branch May 9, 2024 09:56
jmchilton added a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants