Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination support to Files Source plugins #18059

Merged
merged 34 commits into from
May 21, 2024
Merged

Add pagination support to Files Source plugins #18059

merged 34 commits into from
May 21, 2024

Commits on May 21, 2024

  1. Add pagination params to remote file sources

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e2d8164 View commit details
    Browse the repository at this point in the history

  2. Add supports_pagination flag to file sources

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    bd38198 View commit details
    Browse the repository at this point in the history

  3. Implement pagination in Invenio fsplugin

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0151f9e View commit details
    Browse the repository at this point in the history

  4. Add pagination support for all PyFilesystem2 sources

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ad67556 View commit details
    Browse the repository at this point in the history

  5. Add temp file source plugin for easy testing PyFilesystem2

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    508b3e3 View commit details
    Browse the repository at this point in the history

  6. Add unit tests for TempFilesSource

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    080a724 View commit details
    Browse the repository at this point in the history

  7. Fix recursive walking in PyFilesystem2FilesSource 

    This probably never worked as the information required to serialize the files was not there.
    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9fd3443 View commit details
    Browse the repository at this point in the history

  8. Update client API schema

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    451f8c7 View commit details
    Browse the repository at this point in the history

  9. Use default behavior when no pagination params are set

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6aaae24 View commit details
    Browse the repository at this point in the history

  10. Expose offset and limit pagination params in browseRemoteFiles

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8174633 View commit details
    Browse the repository at this point in the history

  11. Refactor unit tests for TempFilesSource

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d0632a5 View commit details
    Browse the repository at this point in the history

  12. Refactor limit and offset query params documentation

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a50d2d3 View commit details
    Browse the repository at this point in the history

  13. Add supports_search flag and query parameter to file sources 

    This flag will inform if the file source plugin is capable of filtering the list of contents by providing a search query string. The supported query syntax is up to the file source implementation, but a basic "search by name" should be supported.
    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    af37cbe View commit details
    Browse the repository at this point in the history

  14. Implement search query in PyFilesystem plugins

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8228d83 View commit details
    Browse the repository at this point in the history

  15. Add unit tests for search query

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ff83166 View commit details
    Browse the repository at this point in the history

  16. Implement search query in Invenio-compatible plugins

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    d42ada3 View commit details
    Browse the repository at this point in the history

  17. Add query parameter to fetcher

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    73b2ff7 View commit details
    Browse the repository at this point in the history

  18. Add supports_sorting flag

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    867333f View commit details
    Browse the repository at this point in the history

  19. Add sortBy parameter to fetcher

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    eadab2d View commit details
    Browse the repository at this point in the history

  20. Refactor query parameter annotations in remote files API

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    e04fa52 View commit details
    Browse the repository at this point in the history

  21. Add missing parameters to abstract method

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    789f0ea View commit details
    Browse the repository at this point in the history

  22. Refactor FilesSourceSupports in FilesSourceProperties

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8b71688 View commit details
    Browse the repository at this point in the history

  23. Add total_matches header to file sources listing 

    This is necessary to handle pagination properly in the UI.
    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    dd60362 View commit details
    Browse the repository at this point in the history

  24. Provide total items from FilesDialog to SelectionDialog 

    This will allow to decouple the total matches from the actual returned items from pagination.
    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    069e4b2 View commit details
    Browse the repository at this point in the history

  25. Implement items provider for server-side pagination

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6354b49 View commit details
    Browse the repository at this point in the history

  26. Adapt unit tests with new response header

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    22b0d14 View commit details
    Browse the repository at this point in the history

  27. Adapt unit tests to use pinia

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c53e1cf View commit details
    Browse the repository at this point in the history

  28. Attempt to fix error when counting directories in Google Cloud Storag… 

    …e plugin
    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    13f8c47 View commit details
    Browse the repository at this point in the history

  29. Attempt 2 to fix error when counting directories in Google Cloud Stor… 

    …age plugin
    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    c7a2640 View commit details
    Browse the repository at this point in the history

  30. Do not use bare except

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ae76501 View commit details
    Browse the repository at this point in the history

  31. Add debouncing time for data dialog search

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    ef30cca View commit details
    Browse the repository at this point in the history

  32. Apply suggestions from code review 

    Replace unused tuple value with `_`

Co-authored-by: John Davis <jdavcs@gmail.com>
    @davelopez @jdavcs
    davelopez and jdavcs committed May 21, 2024
    Configuration menu
    Copy the full SHA
    03d9d12 View commit details
    Browse the repository at this point in the history

  33. Add unit tests for invalid parameters

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    40fbc94 View commit details
    Browse the repository at this point in the history

  34. Raise error when invalid pagination parameters

    @davelopez
    davelopez committed May 21, 2024
    Configuration menu
    Copy the full SHA
    2b2d9b9 View commit details
    Browse the repository at this point in the history