This repository has been archived by the owner on Jul 24, 2020. It is now read-only.
enhance the installation detection of involucro #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbargull
reviewed
May 6, 2018
| @@ -285,7 +286,9 @@ def exec_command(self, involucro_args): | |||
| return res | |||
|
|
|||
| def is_installed(self): | |||
| return os.path.exists(self.involucro_bin) | |||
| if find_executable('involucro') is not None or os.path.exists(self.involucro_bin): | |||
There was a problem hiding this comment.
distutils.spawn.find_executable only does half the job of shutil.which, i.e., it is only checking for existence but not user executability.
I think (given a shutil.which implementation) you'd want something like
if not os.path.dirname(self.involucro_bin):
return shutil.which(self.involucro_bin)
return (os.access(self.involucro_bin, os.F_OK | os.X_OK) and not os.path.isdir(self.involucro_bin))There was a problem hiding this comment.
@mbargull missed that, sorry. Do you think if we find the binary, but it is not executable, that we should install/download a new binary? We should probably error out, isn't it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #110