Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New playpal by ugljesa11ugi and Donowa #1368

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Donowa93
Copy link
Contributor

@Donowa93 Donowa93 commented May 1, 2024

based off a palette by ugljesa11ugi in the freedoom discord. this palette is supposed to be doom compatible, while maintaining as few colors from the og doom palette as possible, as well as adding hueshifting based on brightness.

Why do this?
well, the current playpal is one of the very few files in freedoom that is unchanged from its id counterpart, and having a different but compatible playpal would mean one less potentially copyrighted asset in the iwad.
in addition, a different playpal would help give the game a more unique visual identity compared to doom 1, and could help with shedding the "dollarstore doom" image that most people associate with freedoom

nugg0077
nugg0074
nugg0069
nugg0067
(screenshots taken in nugget doom)

based off a palette by ugljesa11ugi in the freedoom discord. this palette is supposed to be doom compatible, while maintaining as few colors from the og doom palette as possible, as well as adding hueshifting based on brightness.
@Donowa93 Donowa93 changed the title Update playpal-base.lmp Update playpal-base.lmp (NEEDS FIX, WILL UPDATE OR PUT UP A BETTER PR) May 1, 2024
@Talon1024
Copy link
Contributor

I think you should wait until #1108 is added. That script will automatically convert all of Freedoom's graphics from the old palette to the new palette.

note that some graphics here (like the font and one of the necromancer's resurrect frames) are left untouched, and these remaps aren't optimized, but this should fix most of the issues with building
@Donowa93 Donowa93 changed the title Update playpal-base.lmp (NEEDS FIX, WILL UPDATE OR PUT UP A BETTER PR) New playpal by ugljesa11ugi and Donowa May 1, 2024
@Donowa93 Donowa93 marked this pull request as ready for review May 1, 2024 23:38
@Calinou
Copy link
Contributor

Calinou commented May 2, 2024

This looks interesting, but wouldn't this break the appearance of some mods when run with a Freedoom IWAD?

Other than that, I find the plasma color is a definitive upgrade for sure, but the contrast ratio for the overall scene rendering seems pretty high. This results in some maps like E1M1 looking quite dark in the starting area. I'm viewing the images on an OLED display in a dark room, so on a display with worse viewing conditions (e.g. LCD panel in the sunlight), it might look better due to the relative lack of contrast.

@Donowa93
Copy link
Contributor Author

Donowa93 commented May 2, 2024

This looks interesting, but wouldn't this break the appearance of some mods when run with a Freedoom IWAD?

the palette is laid out in the same way as the doom palette, and i've made many changes to try and maintain compatibility with the vanilla pal while still having it be visually distinct

Other than that, I find the plasma color is a definitive upgrade for sure, but the contrast ratio for the overall scene rendering seems pretty high. This results in some maps like E1M1 looking quite dark in the starting area. I'm viewing the images on an OLED display in a dark room, so on a display with worse viewing conditions (e.g. LCD panel in the sunlight), it might look better due to the relative lack of contrast.

i mean i did most of the work on this palette on an lcd in a brightly lit room, but the contrast seems to match the doom palette
newpale1

oldpale1

@fabiangreffrath
Copy link
Contributor

To be honest, I don't think this palette is much of a win. It seems to me that it merely replaces some of the warmer brown/beige shades with some colder blue-ish ones. The whole scene feels a bit colder and blue tinted. I feel the need to enable cold light reduction on my screen to mitigate it, but this pretty much cannot be the intention of a new game palette.

@Donowa93
Copy link
Contributor Author

Donowa93 commented May 8, 2024

To be honest, I don't think this palette is much of a win. It seems to me that it merely replaces some of the warmer brown/beige shades with some colder blue-ish ones. The whole scene feels a bit colder and blue tinted. I feel the need to enable cold light reduction on my screen to mitigate it, but this pretty much cannot be the intention of a new game palette.

it's probably due to how doom is a very dark game and the colormap having no ranges for ranges becoming brighter (unlike quake's colormap) while the palette i have here hueshifts to yellow in light tones and blue in darker tones
in earlier versions i tried making the yellow hueshift more extreme with bright tones, but i scrapped those after i realized that it turned the blood on zombiemen orange (since this is supposed to be doom compatible, i was testing it with different games than just freedoom)
pissblood

for some reason this texture uses a cyan tone instead of alpha, since i have no clue about coding or makefiles i just reverted it to the regular blue
@Anonysussy
Copy link
Contributor

Anonysussy commented May 9, 2024

Screenshot_20240509_095703
I wouldn't say that I hate the palette, but I've play test this palette for probably a week to help finalize my opinion, I think I agreed that the grey palette should be actual grey, they're the most basic colors you're gonna get, your palette wouldn't cut it if it didn't nail the most basic colors, considering how doom PLAYPAL and COLORMAP works, it just make everything bluish and slightly yellow tinted in few areas, it's either look cold blue or Sephia most of the time and it looks off, it made them look like they just tinted for the reason of being tinted and not much more, I prefer my Freedoom palette to retain the Doom palette look without straying away from it.

I think I like the idea of the palette as a whole adding some variety to the colors, but in execution I would prefer something more along the lines standard.

@Anonysussy
Copy link
Contributor

Anonysussy commented May 9, 2024

Screenshot 2024-05-09 192331
Screenshot 2024-05-09 192205
Screenshot 2024-05-09 191012
donopal-edit.zip
Working on some edit for the greys to counteract the bluish look, alongside reworked green palette, i think this looked more on the pinkish side and still pretty rough in comparison, probably gonna work on it later on.

@Donowa93
Copy link
Contributor Author

Donowa93 commented May 9, 2024

while i do admit that i might've made the hueshifting a little too strong for the grays, i think your edit only exacerbates the problem of the grays being tinged by the hueshifting
once i get back home i'm thinking of tweaking the palette though, mainly thinking of reducing the hueshift for the red ranges (or maybe even having the red ranges hueshift to brown at the very low end)

@Anonysussy
Copy link
Contributor

Anonysussy commented May 9, 2024

while i do admit that i might've made the hueshifting a little too strong for the grays, i think your edit only exacerbates the problem of the grays being tinged by the hueshifting once i get back home i'm thinking of tweaking the palette though, mainly thinking of reducing the hueshift for the red ranges (or maybe even having the red ranges hueshift to brown at the very low end)

I whipped that edit up pretty quickly, I'd admit looks worse in comparison, i think the green one is fine and colormaps better as far as from my experiences goes (e.g Reelism 2 HUD), i would still prefer normal greys though, other palette other than greys were pretty passable though.

@Donowa93
Copy link
Contributor Author

Donowa93 commented May 9, 2024

i'm thinking of also reducing the saturation on the gray tones, i still wanna keep the blue/yellow shift since i like how they make the light and dark gray textures more distinct while still being recognizably gray

tweaked the red ranges to work better on the colormap, as well as turning the grays into pure gray and changing the greens to be less saturated (courtesy of Anonysussy)
@Donowa93
Copy link
Contributor Author

just updated, posting this so that it shows on the discord
nugg0120

@Donowa93 Donowa93 requested a review from X64X2 May 18, 2024 19:14
@Xindage
Copy link
Contributor

Xindage commented May 27, 2024

the last screenshot seems more of an acceptable way, can you give us more screenshots?

@fabiangreffrath
Copy link
Contributor

the last screenshot seems more of an acceptable way, can you give us more screenshots?

Yes, before/after screenshots with the original palette would be best.

@Donowa93
Copy link
Contributor Author

the last screenshot seems more of an acceptable way, can you give us more screenshots?

Yes, before/after screenshots with the original palette would be best.

by "original palette", do you mean the doom palette or the older proposal?

@fabiangreffrath
Copy link
Contributor

by "original palette", do you mean the doom palette or the older proposal?

The Doom palette is the one this proposal needs to perform against.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants