Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lumps: Updated custom ENDOOM screens #1359

Merged
merged 9 commits into from
May 5, 2024

Conversation

Anonysussy
Copy link
Contributor

@Anonysussy Anonysussy commented Mar 21, 2024

These were a revised version of the previous custom ENDOOM screens i made a few weeks/months back probably, i don't have much involvement in the previous PR since it got closed off immediately, these new revision fixes a bunch of problems from the previous one.
Screenshot 2024-03-21 205746
Screenshot 2024-03-28 202739

@Anonysussy Anonysussy changed the title lumps: Custom ENDOOM screens lumps: Updated ENDOOM screens Mar 21, 2024
@Anonysussy Anonysussy changed the title lumps: Updated ENDOOM screens lumps: Updated custom ENDOOM screens Mar 21, 2024
Copy link

@Snoucher Snoucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some great changes to the endoom screens, but I think the website portion of the screen has a lot of dead space. Perhaps you could change it to the original text for the website portion to avoid it?

@Anonysussy Anonysussy closed this Apr 2, 2024
@Anonysussy Anonysussy reopened this Apr 2, 2024
@Anonysussy
Copy link
Contributor Author

Anonysussy commented Apr 2, 2024

These are some great changes to the endoom screens, but I think the website portion of the screen has a lot of dead space. Perhaps you could change it to the original text for the website portion to avoid it?

I've come up with the workaround, but when I asked about it fraggle requested me to just remove the row leading to said dead space, (also the closing PR was a misclick my bad)

@Anonysussy
Copy link
Contributor Author

These are some great changes to the endoom screens, but I think the website portion of the screen has a lot of dead space. Perhaps you could change it to the original text for the website portion to avoid it?

Would probably going to work on it though

@Anonysussy
Copy link
Contributor Author

Screenshot 2024-04-03 194853 i think these should probably work out the empty space, also experimenting with the color

Added color for the ENDOOMs and filling up the empty space a bit
@Xindage Xindage merged commit 6e7c506 into freedoom:master May 5, 2024
1 check passed
@Anonysussy Anonysussy deleted the Custom-ENDOOM-screens branch May 6, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants