-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New sounds for the BFG and plasma rifle #1294
base: master
Are you sure you want to change the base?
Conversation
I like them and they definitely work well as far as feel and timing are concerned, though they need to be much louder to sound right ingame. Poking around on bart's OGA profile and they look legit so far... i'm not missing anything, am I? |
If we're about to post a release, my opinion is that this PR should be deferred and the release should not be delayed because of this. However, I'm not going to add the deferred tag because if the release is delayed for totally unrelated reasons and all outstanding issues are addressed on this PR, then it should be merged.
|
Yeah I'm aware that the sounds aren't very loud. My skills with audacity are not the best, but I'll try to fix them sometime soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that in chocolate doom dsrxplod.wav doesn't play to it's end, which creates a noticeable cut off in the audio. We should probably do something about it before we merge it.
Made by MoonDeLaAxel and I, from CC0 sounds.
Sources
https://opengameart.org/content/space-laser
https://opengameart.org/content/doomsday-laser-cannon-sound-effect
https://opengameart.org/content/synthesized-explosion