Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sounds for the BFG and plasma rifle #1294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uhbooh
Copy link
Contributor

@uhbooh uhbooh commented Jan 29, 2024

@mc776 mc776 added the sounds label Jan 29, 2024
@mc776 mc776 requested review from fragglet, selliott512 and a team January 29, 2024 08:24
@mc776
Copy link
Contributor

mc776 commented Jan 29, 2024

I like them and they definitely work well as far as feel and timing are concerned, though they need to be much louder to sound right ingame.

Poking around on bart's OGA profile and they look legit so far... i'm not missing anything, am I?

@mc776
Copy link
Contributor

mc776 commented Jan 29, 2024

If we're about to post a release, my opinion is that this PR should be deferred and the release should not be delayed because of this.

However, I'm not going to add the deferred tag because if the release is delayed for totally unrelated reasons and all outstanding issues are addressed on this PR, then it should be merged.

(frankly from what I had previously been led to believe there should have been a new FD release a couple hours before this PR had even been posted... what happened?) [i have been updated about this]

@mc776
Copy link
Contributor

mc776 commented Jan 29, 2024

While testing #1296 I'd accidentally used a wad that had both that sound and these ones and yeah they are definitely not loud enough... like, the problem #1296 has just solved will have its equivalent pop up with technospiders and deathmatch opponents...

@mc776 mc776 added deferred and removed deferred labels Jan 29, 2024
@uhbooh
Copy link
Contributor Author

uhbooh commented Jan 30, 2024

Yeah I'm aware that the sounds aren't very loud. My skills with audacity are not the best, but I'll try to fix them sometime soon.

Copy link

@Snoucher Snoucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that in chocolate doom dsrxplod.wav doesn't play to it's end, which creates a noticeable cut off in the audio. We should probably do something about it before we merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants