fix(api): reset all claimed certs during reset #54883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform: api
moT01
added
the
status: waiting review
naomi-lgbt
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
mainbranch of freeCodeCamp.Changing this did not trip as many tests as it should have, since we're using more 'fuzzy' assertions like
expect.toMatchObject. I plan to rework a few in a followup PR, but for this I fixed the issues:isFoundationalCSharpCertV8andisJsAlgoDataStructCertV8were not getting reset and new users were not getting the 'free progress timestamp'. i.e. settingprogressTimestamps = [Date.now()]rather than[].We may want to not give that, because it makes very little sense, but it's a post-MVP issue.