New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert universal navigation test to Playwright #54873

Merged

ahmaxed merged 2 commits into freeCodeCamp:main from Sembauke:feat/convert-universal-navigation-to-playwright

May 23, 2024

Member

Sembauke commented May 20, 2024 •

edited

Checklist:

I have read and followed the contribution guidelines.
I have read and followed the how to open a pull request guide.
My pull request targets the main branch of freeCodeCamp.
I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX


          feat: convert universal naviation test to Playwright

49d020c

github-actions bot added the scope: tools/scripts label

Member Author

Sembauke commented May 20, 2024

I will be adding the donation test for the menu in another pr, most likely in #54857

Sembauke marked this pull request as ready for review

May 20, 2024 09:31

Sembauke requested a review from a team as a code owner

May 20, 2024 09:31

moT01 added the status: waiting review label

naomi-lgbt changed the title ~~feat: convert universal naviation test to Playwright~~ feat: convert universal navigation test to Playwright

naomi-lgbt reviewed

View reviewed changes

e2e/header.spec.ts Outdated Show resolved Hide resolved


          Update e2e/header.spec.ts

80d79f9

Co-authored-by: Naomi <accounts+github@nhcarrigan.com>

naomi-lgbt approved these changes

View reviewed changes

Sembauke mentioned this pull request

Remove Cypress #52905

Open

61 tasks

Member

ahmaxed commented May 22, 2024

Thanks for the pr.
The Donor Navigation Menu tests are missing.
Additionally the sign in/sign out and cancelling the sign out tests are missing as well.

Member Author

Sembauke commented May 22, 2024 •

edited

@ahmaxed
#54873 (comment)

See the above comment for the donation tests.

The signout/signin tests are covered in signout-modal.spec.ts

ahmaxed approved these changes

View reviewed changes

ahmaxed merged commit 1e83bed into freeCodeCamp:main

22 checks passed

Sembauke deleted the feat/convert-universal-navigation-to-playwright branch

May 23, 2024 12:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment