feat(curriculum): add Projectile Trajectory project to SciComPy #54839

ilenia-magoni · 2024-05-16T15:53:29Z

Checklist:

I have read and followed the contribution guidelines.
I have read and followed the how to open a pull request guide.
My pull request targets the main branch of freeCodeCamp.
I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

…ers (freeCodeCamp#54004)

…nto reorder-python

…CodeCamp into projectile-trajectory

Dario-DC

Once the tests are fixed, instructions can be refined a bit for the last steps but it's looking very good!

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/662f9f65c50bd21d05ffdee9.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6634fa2417d7194b0c9425f9.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66335223f3e2a31d62d84367.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/663353465bfb14259717da93.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475d40dd42fb614f14fd03.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475e40f3891c645d50135e.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475f7b91d7c6681987739d.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633bdc3ca38c068c3735984.md

zairahira

Reviewed the project and left a few comments.
Also, I wasn't able to pass the steps 18, 19 and 20.

Some steps(like step-2) are too wordy and would need to be revised.

Once Dario's reviews are resolved, I'll take another thorough look.

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660400f02cf3a76795b82d4e.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/65fd4b3bedee044b4b957d33.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660fcf3e1b9bb056b2edb567.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/662fc35902038376c7a00b3c.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633c06601c081735063b528.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475e40f3891c645d50135e.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660400f02cf3a76795b82d4e.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66335223f3e2a31d62d84367.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/663353465bfb14259717da93.md

fhsinchy

I went through the steps. Looks fine to me. I managed to pass all the steps. The text looks great too.

Dario-DC · 2024-05-23T12:53:55Z

client/i18n/locales/english/intro.json

@@ -874,6 +874,10 @@
          "This is one of the required projects to claim your certification."
        ]
      },
+      "learn-encapsulation-by-building-a-projectile-trajectory-calculator": {
+        "title": "Learn Encapsulation by Building a Projectile Trajectory Calculator",
+        "intro": ["", ""]


Remember to add intro.

Dario-DC · 2024-05-23T12:54:13Z

...hallenges/_meta/learn-encapsulation-by-building-a-projectile-trajectory-calculator/meta.json

+  "usesMultifileEditor": true,
+  "hasEditableBoundaries": true,
+  "dashedName": "learn-encapsulation-by-building-a-projectile-trajectory-calculator",
+  "order": 221,


Remember to check the order.

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/65fd4b3bedee044b4b957d33.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6616ec0bf9ee8548ce6b0f08.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633b4d3271d5b3aea1c1195.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633bdc3ca38c068c3735984.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/663353465bfb14259717da93.md

Co-authored-by: Zaira <33151350+zairahira@users.noreply.github.com>

zairahira

I have reviewed all the steps, the tests ran fine for all of them.
I have left a couple of comments, after that the project is ready to go from my end.

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/662f9f65c50bd21d05ffdee9.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/662fa453ec8033322b3ab2e3.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475bab40e5125c84b03337.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660400f02cf3a76795b82d4e.md

ilenia-magoni · 2024-05-29T10:25:22Z

...ting-with-python/learn-encapsulation-by-building-a-projectile-trajectory-calculator/index.md

Needs to be fleshed out, see #43289 (comment)

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/65f569725359e10d345bc52a.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/65fd4bd84561a14d3e720061.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/660400f02cf3a76795b82d4e.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475d40dd42fb614f14fd03.md

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475e40f3891c645d50135e.md

gikf · 2024-05-30T18:01:27Z

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/66475d40dd42fb614f14fd03.md

+print(ball)
+coordinates = ball.calculate_all_coordinates()
+graph = Graph(coordinates)
+print(graph.create_trajectory())


This isn't very readable in next steps, which might make it harder to get the correct results.

Maybe another step could be added to change it for couple steps?:

for row in graph.create_trajectory() print(row)

gikf · 2024-05-30T18:23:14Z

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633bdc3ca38c068c3735984.md

+```py
+[
+    "⊣     ∙       ",
+    "⊣  ∙∙∙ ∙∙∙    ",
+    "⊣ ∙       ∙   ",
+    "⊣∙         ∙  ",
+    "⊣           ∙ ",
+    "⊣            ∙",
+    "⊣             ",
+    " ⊤⊤⊤⊤⊤⊤⊤⊤⊤⊤⊤⊤⊤",
+]
+```


Is it just me, or this is not fully looking like it should?

Are the special characters messing up mono-spacing?

Yes, they are messing up the mono-spacing, let me see if I find a different character...

gikf · 2024-05-30T18:33:59Z

...arn-encapsulation-by-building-a-projectile-trajectory-calculator/6633bfcef57e1d70cc3142c6.md

+The method `create_trajectory` should return `graph`.
+
+```js
+({
+    test: () => runPython(`
+    assert _Node(_code).find_class('Graph').find_function('create_trajectory').has_return('graph'), "return graph missing"
+    `)
+})
+```


If the exact value from function is tested (next hint) I think it's fine to not check how the returned thing is named in function. This likely apply to couple other steps.

…nto pr/ilenia-magoni/54839

Dario-DC and others added 30 commits March 21, 2024 10:38

chore(curriculum): put Python certification projects in separate fold…

4e37060

…ers (freeCodeCamp#54004)

Merge branch 'main' of https://github.com/freeCodeCamp/freeCodeCamp i…

1ccf56a

…nto reorder-python

Merge branch 'main' of https://github.com/freeCodeCamp/freeCodeCamp i…

74a3707

…nto reorder-python

create new project

f453405

create new project

2cc17d3

instructions for first 4 steps

b0a271a

first 4 steps instuctions

0bd423b

firt test

f85cf4e

change dashed name

138d705

tests steps 1-5

9a91f47

step 6

40cfa9c

step 7

d16aaac

fix typo

1ef3373

refactor test in step 7

4bb796d

step 8

956f7cc

Note: MathJax?

512856b

up to step 10

1d0f2af

steps 10-11

05f0ad3

+

6934d4d

step 12

24a43ad

step 17

e806708

typos

01aacd9

fix: typo

e9bc101

Merge branch 'main' of https://github.com/freeCodeCamp/freeCodeCamp i…

fc77aa5

…nto reorder-python

up to step 22

4c3f7e1

Merge branch 'reorder-python' of https://github.com/freeCodeCamp/free…

b818dac

…CodeCamp into projectile-trajectory

step 22

78be837

create new project

b691a66

create new project

c4a3e55

instructions for first 4 steps

e0c0a24

new batch of steps for graph

8dab751

ilenia-magoni added status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. and removed status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP labels May 20, 2024

ilenia-magoni requested review from Dario-DC, fhsinchy, zairahira and larymak May 20, 2024 10:31

zairahira self-assigned this May 20, 2024

Dario-DC requested changes May 20, 2024

View reviewed changes

zairahira reviewed May 21, 2024

View reviewed changes

action review comments

26df060

ilenia-magoni requested review from Dario-DC and zairahira May 21, 2024 14:03

ilenia-magoni added 3 commits May 21, 2024 16:10

typo

10d81ff

typo

9c518af

tYpO

515b553

fhsinchy approved these changes May 22, 2024

View reviewed changes

Dario-DC reviewed May 23, 2024

View reviewed changes

zairahira reviewed May 23, 2024

View reviewed changes

Apply suggestions from code review

3dcaf0c

Co-authored-by: Zaira <33151350+zairahira@users.noreply.github.com>

zairahira reviewed May 23, 2024

View reviewed changes

Apply suggestions from review

21879af

ilenia-magoni requested a review from Dario-DC May 24, 2024 15:48

fix order

68a21ab

ilenia-magoni commented May 29, 2024

View reviewed changes

gikf reviewed May 30, 2024

View reviewed changes

ilenia-magoni added 4 commits June 3, 2024 11:27

change special symbol to one actually monospace

185ac4e

Merge branch 'main' of https://github.com/freeCodeCamp/freeCodeCamp i…

268b678

…nto pr/ilenia-magoni/54839

change meta.json

914faf6

changes from review

f3a6393

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(curriculum): add Projectile Trajectory project to SciComPy #54839

feat(curriculum): add Projectile Trajectory project to SciComPy #54839

ilenia-magoni commented May 16, 2024

Dario-DC left a comment

zairahira left a comment

fhsinchy left a comment

Dario-DC May 23, 2024

Dario-DC May 23, 2024

zairahira left a comment

ilenia-magoni May 29, 2024

gikf May 30, 2024

gikf May 30, 2024

ilenia-magoni May 31, 2024

gikf May 30, 2024

feat(curriculum): add Projectile Trajectory project to SciComPy #54839

Are you sure you want to change the base?

feat(curriculum): add Projectile Trajectory project to SciComPy #54839

Conversation

ilenia-magoni commented May 16, 2024

Dario-DC left a comment

Choose a reason for hiding this comment

zairahira left a comment

Choose a reason for hiding this comment

fhsinchy left a comment

Choose a reason for hiding this comment

Dario-DC May 23, 2024

Choose a reason for hiding this comment

Dario-DC May 23, 2024

Choose a reason for hiding this comment

zairahira left a comment

Choose a reason for hiding this comment

ilenia-magoni May 29, 2024

Choose a reason for hiding this comment

gikf May 30, 2024

Choose a reason for hiding this comment

gikf May 30, 2024

Choose a reason for hiding this comment

ilenia-magoni May 31, 2024

Choose a reason for hiding this comment

gikf May 30, 2024

Choose a reason for hiding this comment