Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jira Links Endpoint #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cthenderson
Copy link

Adding additional endpoint for fetching JIra issue links.

@fprimex
Copy link
Owner

fprimex commented Jan 26, 2022

Hi, thanks for the contribution. The zdesk_api.py is generated from zdgen. I would like to leave this open for those who might be looking for the same thing, then fix this over in zdgen. They've changed the docs layout and I've started working on updates to account for that.

@fprimex
Copy link
Owner

fprimex commented Jan 28, 2022

I have a branch created with an updated zdgen:

https://github.com/fprimex/zdesk/tree/doc_site_update

Can you see if this will work for you? They have changed a lot of things (for the better) while migrating their docs site, so you may have to make some changes. Notably, every id argument they had became more descriptive. Instead of id they now have, e.g., ticket_id.

@cthenderson
Copy link
Author

cthenderson commented Feb 1, 2022

Thanks for getting this update in. I noticed the call method was causing an infinite loop when I passed in path=/api/v2/jira/links, get_all_pages=True. I created a PR with the doc_site_update as the base to handle all of the paging responses.

#64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants