-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump to latest alloy and revm #7934
Conversation
Supersedes #7933 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
early comment
We need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nits, and as discussed we can set the lastCallGas gasMemoryUsed to 0 and soft deprecate it.
@@ -551,19 +551,19 @@ impl InspectorStack { | |||
let (result, address, output) = match res.result { | |||
ExecutionResult::Success { reason, gas_used, gas_refunded, logs: _, output } => { | |||
gas.set_refund(gas_refunded as i64); | |||
gas.record_cost(gas_used); | |||
let _record_gas = gas.record_cost(gas_used); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine because it's a new Gas instance, I added must_use for use within EVM instructions.
needs clippy |
this test appears to be flaky testStorageAccessDelegateCall on multiple platforms, unsure if related to this pr |
likely some incorrect address migration in cheatcodes |
Yeah I'll investigate |
@mattsse it's not flaky if it actually fails :D |
Clippy failing due to docs, should be fixed by #7975 |
great, just resolved 1 smol conflict |
* revert to alloy f415827 * revm-inspectors bump 098ab30 * deny.toml nit * satisfy AccessListInspector trait bounds * bump revm * map Opcode * nit * fix: revm `CallInputs` for cheatcodes/inspector * remove: `BlockId::latest()` calls * use unwrap_or_default * fix: evm/coverage * fix: evm/fuzz * fix: cheatcodes * fix: evm executors and inspectors * fix: anvil & verify * fix: add `AnvilAccessListInspector` to satisfy trait bounds * fix: anvil tests * clippy: rm unused * fmt * fix: cheatcodes inspector revm `CallInputs` * rm spec arg * use OPCODE_INFO_JUMPTABLE * nit * rm wrapped inspectors * fix: anvil test can_sign_tx * fix: evm deser cache tests * deprecate gas memory recording * nits * nit * nits * ci nits * fix: use `call.bytecode_address` instead of `call.target_address` * nit Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> * fix arg * rm forge-std --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Motivation
Bump alloy. Fixes #7932
Solution
Redo RPC calls