-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat(fuzz) - add test progress #7914
base: master
Are you sure you want to change the base?
Conversation
I think we could add a termination check with something like an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaniPopes should be proceed with this given that this is opt in for now and do a larger cleanup for the nested suite par_iter and exit early separately or do this here?
@@ -166,6 +166,61 @@ macro_rules! update_progress { | |||
}; | |||
} | |||
|
|||
/// Creates progress object and progress bar. | |||
#[macro_export] | |||
macro_rules! init_tests_progress { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is how it exists already, but I'd like these macros to be helper functions and/or structs instead, since that's all they are
let result = self.run_tests(id, contract, db.clone(), filter, &handle); | ||
let _ = tx.send((id.identifier(), result)); | ||
}) | ||
if show_progress { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok with this for now, but I think we want to have one single par_iter here and also handle all output in between progress bars
Motivation
Closes #585
Closes #3277
Closes #4452
Solution
indicatif
crate--show-progress
arg (to give more time for feedback / OS tests, then make it default and add a--stream-results
flag for legacy output)[current / total]
runs; Invariants show[current / total]
runs and then the[current shrink / max shrink]
runs (if case)TBD: rn the fail fast flag doesn't stop test case execution (rayon par iter continue to run until all tasks are completed), need to find a way to exit early when such